Skip to content

ops(0-0-0): LFG forward-sync — post-reset cleanup + Copilot fixes + pr-preservation drain-logs (mirror of AceHack #101)#845

Merged
AceHack merged 3 commits intomainfrom
post-0-0-0-cleanup-2026-04-29
Apr 29, 2026
Merged

ops(0-0-0): LFG forward-sync — post-reset cleanup + Copilot fixes + pr-preservation drain-logs (mirror of AceHack #101)#845
AceHack merged 3 commits intomainfrom
post-0-0-0-cleanup-2026-04-29

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented Apr 29, 2026

Summary

LFG forward-sync PR for the AceHack-first cleanup that landed at AceHack#101 (merged 2026-04-29T14:19:41Z, squash → 5485772e87d74f3b96cdac4f39063cb0e82d7839).

This is step 2 of the canonical double-hop: AceHack-first (#101 ✓) → LFG forward-sync (this PR) → AceHack absorbs LFG squash-SHA (after this merges).

Diff vs LFG main (same content as AceHack #101 + LFG-side review fixes + pr-preservation files)

  1. Original cleanup commits (from AceHack auto-loop-10 tick-history row — unblock tick-history PR chain via Copilot review address + PR #99 redundancy-close #101): stale-prose fixes in docs/active-trajectory.md, protection-config memory file, MEMORY.md index entry, tick shard 1410Z

  2. LFG ops(0-0-0): post-reset cleanup — stale-prose fixes + protection-config memory #844 Codex P2 fix (commit f6d6a94): gh api --input syntax corrected to heredoc-stdin pattern

  3. LFG ops(0-0-0): post-reset cleanup — stale-prose fixes + protection-config memory #844 Copilot thread fixes (this commit):

  4. PR-preservation drain-logs (Aaron 2026-04-29 directive): docs/pr-preservation/lfg-844-drain-log.md + docs/pr-preservation/acehack-101-drain-log.md — verbatim threads + responses + outcome classes for both PRs in this double-hop round

Sequence after this PR merges

  1. LFG/main advances to new squash-SHA = <TBD>
  2. AceHack/main is at 5485772... (post-auto-loop-10 tick-history row — unblock tick-history PR chain via Copilot review address + PR #99 redundancy-close #101); LFG/main moves to <TBD> (post-this)
  3. Force-push acehack/main → LFG/main <TBD> (toggle ruleset / push / restore — same pattern as the 0/0/0 hard-reset)
  4. AceHack/main = LFG/main = <TBD> — 0/0/0 invariant restored

Authority boundary

Step 3 (force-push to AceHack) is irreversible from the ref-perspective + requires ruleset toggle → gates on Aaron's authority. After this PR merges, I prepare the verify-only gate packet for the absorption push, then await Aaron's EXECUTE.

Also addresses Copilot review feedback from LFG #844 carried forward.

🤖 Generated with Claude Code

AceHack added 3 commits April 29, 2026 10:13
…e fixed, protection-config memory landed

Completes Amara's prescribed post-reset cleanup PR: stale-prose drift in active-trajectory.md fixed + protection-config finding documented.

## 0/0/0 ACHIEVED (2026-04-29T14:04:50Z)

- AceHack/main = LFG/main = 621aae0
- Topology: 0 ahead, 0 behind, 0 file content diff
- Old AceHack tip preserved at archive/acehack-main-pre-000-reset-2026-04-29 → 6755081...
- Legacy branch protection DELETED per Aaron; rulesets canonical going forward

## Stale-prose fixes (active-trajectory.md)

Two paragraphs flipped from pre-reset state to in-force post-reset state:
- Line 221: "Currently NOT signoff-eligible" → "0/0/0 ACHIEVED 2026-04-29T14:04:50Z..."
- Line 413: "Hard-reset is NOT YET signoff-eligible" → "Hard-reset complete (2026-04-29T14:04:50Z)..."

Per Amara's substrate-pass catch (2026-04-29 buddy review): residual prose contradicted the 273/0/0 ledger state. This is Derived-Rollup Drift class.

## Protection-config memory file

`memory/feedback_acehack_zeta_protection_config_dual_layer_legacy_deleted_rulesets_canonical_2026_04_29.md` documents:
- AceHack/Zeta had BOTH legacy branch protection AND repository rulesets on main
- Both layers enforced independently; GitHub UI doesn't surface dual-layer state
- Aaron's confirmation: "I knew there were two but I was confused why"
- Maintainer call: legacy DELETED; rulesets canonical
- Error-code mapping: GH013 = rulesets surface; GH006 = legacy surface
- Diagnostic script (gh api commands) for future protection-config audits
- Future-protocol note: rulesets non_fast_forward rule still doesn't match CLAUDE.md "force-push to AceHack main is part of protocol" — task #305 home for that decision

MEMORY.md index updated with one-line pointer.

## Tick shard 1410Z

Records the entire 0/0/0 hard-reset arc:
- Triple-check buddy review (Amara approved meaningful-content-loss-free)
- Verify-only gate packet (5/5 PASS at 13:39Z)
- Aaron's explicit EXECUTE at 13:58Z
- Step A (archive ref preservation) succeeded
- Step B (force-push) failed twice — GH013 then GH006 — discovered dual-layer protection
- Aaron's "leave legacy off" decision
- Path 1 v3 succeeded at 14:04:50Z
- Trap-restore re-enabled rulesets only

## Per Amara post-reset framework

This PR is the small in-lane cleanup. After it merges:
- Recovery lane starts in INVENTORY-ONLY mode (per Amara's 7-bucket framework: ALREADY_REACHABLE / OBSOLETE_SUPERSEDED / PRESERVE_REF_ONLY / OPEN_PR_CANDIDATE / EXTRACT_MEMORY_OR_DOC / NEEDS_AARON_DECISION / CORRUPT_OR_UNREADABLE)
- 918 branches + 58 worktrees + 7 stashes inventoried at /tmp/recovery-inventory-2026-04-29.tsv
- No mutation until classification summary reviewed
- Deferred queue P1 consolidation (8 rule candidates) waits per Amara's "trigger after hard-reset success" rule — now satisfied, but lane discipline keeps it in P1 not P0

## Authority boundary going forward

- Reversible + in-lane + PR-reviewed → proceed autonomously
- Irreversible / deletion / force-push / authority config / identity canon → ask Aaron
- Unclear → stop, report exact uncertainty, propose one safe action
…ection-config memory

Codex caught a real defect in the memory file: documented `gh api --input '{json}'` but `--input` takes a FILE PATH, not inline JSON. Future readers copy-pasting would hit failure.

Fix: rewrite the Executed section to show the actual heredoc-from-stdin pattern that was used during the live operation:
  gh api -X PUT ... --input - <<'EOF'
  {"enforcement": "disabled"}
  EOF

Plus added a clarifying note explaining the gh CLI flag semantics (--input <file>, --input - for stdin, -f/-F for typed inline fields). Memory file is now copy-paste-correct.
…add pr-preservation drain-logs for #844 + #101

Carry-forward fixes for the 4 unresolved Copilot threads from LFG #844 (closed in favor of canonical AceHack-first reopening as AceHack #101 + this LFG forward-sync). Plus pr-preservation discipline going forward (Aaron 2026-04-29): every PR closed/merged → drain-log on LFG.

## Copilot thread fixes (memory file)

1. **Internal consistency on legacy DELETE response** (Copilot Thread 3) — the 404 came from my POST-DELETE verification GET, not from DELETE itself. DELETE returned rc=0 (success / 204 No Content); subsequent GET returned 404 "Branch not protected". Memory file now reflects the two-step accurately.

2. **"Task #305" wrong reference** (Copilot Thread 4) — should be **task #275** ("Set up acehack-first development workflow") in the in-session TaskList. Updated. Plus added clarifying parenthetical noting in-session-TaskList vs PR-numbers vs backlog-B-#### are distinct namespaces.

3. **Wording nit "the only rulesets ruleset"** (Copilot Thread 5) — adopted suggested rephrasing to "the only ruleset".

4. **`gh api --input` syntax** (Codex Thread 1, already RESOLVED in commit f6d6a94; Copilot Thread 2 is a duplicate finding addressed by the same fix).

## PR-preservation drain-logs (Aaron 2026-04-29 directive: every PR → drain-log on LFG)

`docs/pr-preservation/lfg-844-drain-log.md`:
- LFG #844 closed not merged (in favor of canonical AceHack-first)
- 5 threads total: 1 Codex P2 (RESOLVED-AS-FIXED) + 4 Copilot (UNRESOLVED-CARRIED-FORWARD-AS-FIX, addressed by this commit)
- Verbatim reviewer text + my response per thread
- Outcome class summary + lessons-for-future

`docs/pr-preservation/acehack-101-drain-log.md`:
- AceHack #101 merged 14:19:41Z (squash → 5485772)
- 0 review threads (AceHack has no Codex/Copilot reviewers + weaker required-status-checks rule)
- Notes the **double-hop training-data observation**: AceHack's review surface is sparser than LFG's; the double-hop captures both, including the silence on AceHack as signal about the review-coverage asymmetry

## Going forward

Per Aaron 2026-04-29: "we need to go through every PR review thread and make sure all there comments and our responses are saved and backed up git native too, and we should just be doing this everytime form now on going forwoard without fail just like resolving them. lfg should have a home already for this data from forks so it can collection fork specific data for those forks who want to send it, lfg also has a connoncial spot for the repo."

Discipline: every PR (closed or merged, AceHack or LFG side) → drain-log file at `docs/pr-preservation/{fork}-{number}-drain-log.md` on LFG. Verbatim reviewer text + responses + outcome class. This collects high-signal training data for the alignment-experiment evaluation surface. Fork-specific naming (`lfg-`/`acehack-`/etc.) disambiguates per-fork numbering collisions.
Copilot AI review requested due to automatic review settings April 29, 2026 14:25
@AceHack AceHack enabled auto-merge (squash) April 29, 2026 14:25
@AceHack AceHack merged commit 3785124 into main Apr 29, 2026
25 checks passed
@AceHack AceHack deleted the post-0-0-0-cleanup-2026-04-29 branch April 29, 2026 14:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Forward-syncs the AceHack-first post-reset cleanup into LFG, preserving operational learnings from the 0/0/0 reset and capturing PR review/drain artifacts as durable history.

Changes:

  • Adds/updates protection-config operational memory (dual-layer legacy branch protection vs rulesets) and indexes it in memory/MEMORY.md.
  • Updates docs/active-trajectory.md to reflect the now-achieved 0/0/0 state (replacing stale pre-reset “not signoff-eligible” language).
  • Adds PR-preservation drain logs for both sides of the double-hop and appends the 14:10Z tick-history shard.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
memory/feedback_acehack_zeta_protection_config_dual_layer_legacy_deleted_rulesets_canonical_2026_04_29.md Documents the dual-layer protection discovery, error-code mapping, and the operational sequence (incl. corrected gh api --input - usage).
memory/MEMORY.md Adds an index entry pointing to the new protection-config memory.
docs/pr-preservation/lfg-844-drain-log.md Records LFG-side PR #844 review threads and resolutions for training-signal preservation.
docs/pr-preservation/acehack-101-drain-log.md Records AceHack-side PR #101 outcome (auto-merged/no-review) for the double-hop record.
docs/hygiene-history/ticks/2026/04/29/1410Z.md Adds the 14:10Z tick shard row capturing the reset completion + cleanup PR opening.
docs/active-trajectory.md Updates trajectory text to reflect the completed hard-reset and new next-action lane.

AceHack added a commit to AceHack/Zeta that referenced this pull request Apr 29, 2026
…PO + fork-naming rename (clean-base) (#103)

* ops(0-0-0): address LFG Lucent-Financial-Group#844 Copilot threads (3 fixes + 1 wording) + add pr-preservation drain-logs for Lucent-Financial-Group#844 + #101

Carry-forward fixes for the 4 unresolved Copilot threads from LFG Lucent-Financial-Group#844 (closed in favor of canonical AceHack-first reopening as AceHack #101 + this LFG forward-sync). Plus pr-preservation discipline going forward (Aaron 2026-04-29): every PR closed/merged → drain-log on LFG.

## Copilot thread fixes (memory file)

1. **Internal consistency on legacy DELETE response** (Copilot Thread 3) — the 404 came from my POST-DELETE verification GET, not from DELETE itself. DELETE returned rc=0 (success / 204 No Content); subsequent GET returned 404 "Branch not protected". Memory file now reflects the two-step accurately.

2. **"Task Lucent-Financial-Group#305" wrong reference** (Copilot Thread 4) — should be **task Lucent-Financial-Group#275** ("Set up acehack-first development workflow") in the in-session TaskList. Updated. Plus added clarifying parenthetical noting in-session-TaskList vs PR-numbers vs backlog-B-#### are distinct namespaces.

3. **Wording nit "the only rulesets ruleset"** (Copilot Thread 5) — adopted suggested rephrasing to "the only ruleset".

4. **`gh api --input` syntax** (Codex Thread 1, already RESOLVED in commit f6d6a94; Copilot Thread 2 is a duplicate finding addressed by the same fix).

## PR-preservation drain-logs (Aaron 2026-04-29 directive: every PR → drain-log on LFG)

`docs/pr-preservation/lfg-844-drain-log.md`:
- LFG Lucent-Financial-Group#844 closed not merged (in favor of canonical AceHack-first)
- 5 threads total: 1 Codex P2 (RESOLVED-AS-FIXED) + 4 Copilot (UNRESOLVED-CARRIED-FORWARD-AS-FIX, addressed by this commit)
- Verbatim reviewer text + my response per thread
- Outcome class summary + lessons-for-future

`docs/pr-preservation/acehack-101-drain-log.md`:
- AceHack #101 merged 14:19:41Z (squash → 5485772)
- 0 review threads (AceHack has no Codex/Copilot reviewers + weaker required-status-checks rule)
- Notes the **double-hop training-data observation**: AceHack's review surface is sparser than LFG's; the double-hop captures both, including the silence on AceHack as signal about the review-coverage asymmetry

## Going forward

Per Aaron 2026-04-29: "we need to go through every PR review thread and make sure all there comments and our responses are saved and backed up git native too, and we should just be doing this everytime form now on going forwoard without fail just like resolving them. lfg should have a home already for this data from forks so it can collection fork specific data for those forks who want to send it, lfg also has a connoncial spot for the repo."

Discipline: every PR (closed or merged, AceHack or LFG side) → drain-log file at `docs/pr-preservation/{fork}-{number}-drain-log.md` on LFG. Verbatim reviewer text + responses + outcome class. This collects high-signal training data for the alignment-experiment evaluation surface. Fork-specific naming (`lfg-`/`acehack-`/etc.) disambiguates per-fork numbering collisions.

* ops(0-0-0): post-#101 follow-up — fix Copilot threads + add full PR archives + correct cross-fork drain-log

Addresses 4 Copilot threads from AceHack #101 (filed 14:24:11Z, AFTER auto-merge fired at 14:19:41Z) + 4 Copilot threads from LFG Lucent-Financial-Group#844 (already addressed in Lucent-Financial-Group#845 but Copilot also reviewed AceHack #101 and re-flagged 2 of them since the AceHack-side hadn't received the carry-forward yet) + Amara post-Lucent-Financial-Group#845 substantive correction on PR-preservation tool usage.

## Copilot thread fixes (memory file)

1. **P1 broken xref** to `memory/feedback_aaron_visibility_constraint_no_changes_he_cant_see_2026_04_28.md` (the file lives in user-scope memory only, not in-repo; cross-reference was therefore broken). Fixed: replaced with prose pointer to the underlying principle + note flagging the same issue exists in MEMORY.md index.

2. **P1 internal consistency on legacy DELETE response** — same finding as LFG Lucent-Financial-Group#844 Thread 3, addressed by carry-forward in LFG Lucent-Financial-Group#845. Now reflected on AceHack via this commit.

3. **P2 wording "the only rulesets ruleset"** — same finding as LFG Lucent-Financial-Group#844 Thread 5, addressed by carry-forward in LFG Lucent-Financial-Group#845. Now reflected on AceHack via this commit.

4. **P2 MEMORY.md index entry too long** — trimmed from a 4-line dense paragraph to a single concise line per `memory/README.md` discipline. Detail stays in the linked memory file.

## PR archives (Amara post-Lucent-Financial-Group#845 directive: use existing `tools/pr-preservation/archive-pr.sh`)

Three full-archive files added under `docs/pr-discussions/`:

- `PR-0844-...md` — closed LFG Lucent-Financial-Group#844 (5 threads, 2 reviews, 2 issue comments)
- `PR-0845-...md` — merged LFG Lucent-Financial-Group#845 (0 threads, 1 review, 0 comments — clean forward-sync)
- `PR-acehack-0101-...md` — merged AceHack #101 (4 threads, 1 review, 0 comments). **Fork-prefixed filename** to disambiguate from LFG #101 (which is a different unrelated PR from 2026-04-22 about auto-loop-10 tick-history). The existing tool's `gh repo view --json owner,name` call resolves to current-clone origin; for cross-fork archives, set `gh repo set-default <fork>/<repo>` first then run, then reset default. Captured as a tool-improvement candidate (the script could accept a `--repo` arg to make cross-fork archives one-shot).

## Drain-log correction for AceHack #101

The earlier drain-log claimed 0 threads (because I queried before Copilot's review landed at 14:24:11Z, ~5 min after auto-merge). Updated to reflect the actual 4 unresolved threads + their carry-forward resolution paths.

## Lesson captured (drain-log, lessons section)

**AceHack auto-merge races Copilot review.** Without required-conversation-resolution + required-status-checks on AceHack, auto-merge fires before reviewers land threads. Threads still apply to merged content; just need a follow-up cycle to land fixes. This is exactly what this PR is — the follow-up.

**The double-hop captures BOTH waves of review.** When AceHack auto-merges fast, the LFG forward-sync PR re-runs review and catches the same findings. Double-hop is also a *redundancy mechanism* against fast-merge-on-AceHack.

## Lane discipline

This PR opens AceHack-first per canonical double-hop. After merge → forward-sync to LFG. After both merge → AceHack absorbs LFG squash-SHA (gates on Aaron's EXECUTE). Then the post-cleanup-cleanup-cleanup is FINALLY done, and we can pivot to recovery-lane classification.

Per Amara: "Double-hop close is the active lane. Do not start branch/worktree recovery until: PR full archives are committed, LFG Lucent-Financial-Group#845 artifacts are preserved, AceHack absorption completes, 0/0/0 is re-verified."

* tools/pr-preservation: archive-pr.sh — add GH_REPO env var override for cross-fork archives (Aaron 2026-04-29)

Per Aaron 2026-04-29: "respect GH_REPO we should fix"

The script previously hard-resolved the target repo via `gh repo view --json nameWithOwner`, which always returns the current-clone's repo (typically `Lucent-Financial-Group/Zeta`). For cross-fork archives — e.g., archiving an AceHack PR from a clone tracking LFG — this returned the wrong repo and the script either:
- Archived the WRONG PR (a same-numbered PR in the default repo), or
- Failed silently / produced misleading filename slugs.

Workaround: `gh repo set-default <fork>/<repo>` before running, then reset after. Awkward and error-prone.

Fix: the script now respects a `GH_REPO=<owner>/<name>` env var before falling back to `gh repo view`. Resolution order:

1. `GH_REPO` env var → use as `<owner>/<name>` (cross-fork archives)
2. `gh repo view --json nameWithOwner` → fall back to default-repo resolution

Also added an `<owner>/<name>` shape validator so a malformed GH_REPO value (no slash) hard-fails early instead of generating bogus output.

Verification: re-ran `GH_REPO=AceHack/Zeta tools/pr-preservation/archive-pr.sh 101` — script now correctly resolves to #101 and writes the archive with the right title/slug, instead of grabbing LFG/Zeta#101 (an unrelated 2026-04-22 PR with completely different content).

Cross-fork filename-collision discipline (separate convention, applied manually for now): when archiving cross-fork PRs that may have number collisions with the default repo, use a fork-prefixed filename like `PR-acehack-<NNNN>-<slug>.md`. This isn't yet in the tool — future enhancement candidate would auto-prefix when GH_REPO ≠ default-repo.

* ops: rename memory file to drop fork-prefix per Aaron's naming rule

Aaron 2026-04-29: "AceHack/Zeta we should not use a forks name in the main repo except for the special section for forks data that is unique to them like pr reviews, budgets, settings, maybe more."

Memory directory is general substrate, NOT a fork-specific section like docs/pr-discussions/ or docs/pr-preservation/. The fork-prefix in `feedback_acehack_zeta_*` filename was therefore misplaced — the file's content describes AceHack/Zeta-specific config but the filename shouldn't repeat that.

Renamed:
  memory/feedback_acehack_zeta_protection_config_dual_layer_legacy_deleted_rulesets_canonical_2026_04_29.md
→ memory/feedback_protection_config_dual_layer_legacy_deleted_rulesets_canonical_2026_04_29.md

Updated cross-references:
- memory/MEMORY.md (index pointer)
- docs/pr-discussions/PR-acehack-0101-...md (archive)
- docs/pr-discussions/PR-0844-...md (archive)
- docs/pr-discussions/PR-0845-...md (archive)
- docs/pr-preservation/lfg-844-drain-log.md
- docs/pr-preservation/acehack-101-drain-log.md

Fork-prefix discipline going forward (per Aaron):
- USE fork-prefix in: docs/pr-discussions/, docs/pr-preservation/, settings dirs, budget dirs (any fork-specific section)
- DO NOT USE fork-prefix in: memory/, src/, docs/ general areas, tools/, anywhere not explicitly fork-scoped

The file's CONTENT still references AceHack/Zeta as the specific repo it documents — that's substantive and correct. Just the filename doesn't repeat the fork name.
AceHack added a commit that referenced this pull request Apr 29, 2026
… archives + GH_REPO + fork-naming rename (#846)

* ops(0-0-0): post-#101 follow-up — fix Copilot threads + add full PR archives + correct cross-fork drain-log

Addresses 4 Copilot threads from AceHack #101 (filed 14:24:11Z, AFTER auto-merge fired at 14:19:41Z) + 4 Copilot threads from LFG #844 (already addressed in #845 but Copilot also reviewed AceHack #101 and re-flagged 2 of them since the AceHack-side hadn't received the carry-forward yet) + Amara post-#845 substantive correction on PR-preservation tool usage.

## Copilot thread fixes (memory file)

1. **P1 broken xref** to `memory/feedback_aaron_visibility_constraint_no_changes_he_cant_see_2026_04_28.md` (the file lives in user-scope memory only, not in-repo; cross-reference was therefore broken). Fixed: replaced with prose pointer to the underlying principle + note flagging the same issue exists in MEMORY.md index.

2. **P1 internal consistency on legacy DELETE response** — same finding as LFG #844 Thread 3, addressed by carry-forward in LFG #845. Now reflected on AceHack via this commit.

3. **P2 wording "the only rulesets ruleset"** — same finding as LFG #844 Thread 5, addressed by carry-forward in LFG #845. Now reflected on AceHack via this commit.

4. **P2 MEMORY.md index entry too long** — trimmed from a 4-line dense paragraph to a single concise line per `memory/README.md` discipline. Detail stays in the linked memory file.

## PR archives (Amara post-#845 directive: use existing `tools/pr-preservation/archive-pr.sh`)

Three full-archive files added under `docs/pr-discussions/`:

- `PR-0844-...md` — closed LFG #844 (5 threads, 2 reviews, 2 issue comments)
- `PR-0845-...md` — merged LFG #845 (0 threads, 1 review, 0 comments — clean forward-sync)
- `PR-acehack-0101-...md` — merged AceHack #101 (4 threads, 1 review, 0 comments). **Fork-prefixed filename** to disambiguate from LFG #101 (which is a different unrelated PR from 2026-04-22 about auto-loop-10 tick-history). The existing tool's `gh repo view --json owner,name` call resolves to current-clone origin; for cross-fork archives, set `gh repo set-default <fork>/<repo>` first then run, then reset default. Captured as a tool-improvement candidate (the script could accept a `--repo` arg to make cross-fork archives one-shot).

## Drain-log correction for AceHack #101

The earlier drain-log claimed 0 threads (because I queried before Copilot's review landed at 14:24:11Z, ~5 min after auto-merge). Updated to reflect the actual 4 unresolved threads + their carry-forward resolution paths.

## Lesson captured (drain-log, lessons section)

**AceHack auto-merge races Copilot review.** Without required-conversation-resolution + required-status-checks on AceHack, auto-merge fires before reviewers land threads. Threads still apply to merged content; just need a follow-up cycle to land fixes. This is exactly what this PR is — the follow-up.

**The double-hop captures BOTH waves of review.** When AceHack auto-merges fast, the LFG forward-sync PR re-runs review and catches the same findings. Double-hop is also a *redundancy mechanism* against fast-merge-on-AceHack.

## Lane discipline

This PR opens AceHack-first per canonical double-hop. After merge → forward-sync to LFG. After both merge → AceHack absorbs LFG squash-SHA (gates on Aaron's EXECUTE). Then the post-cleanup-cleanup-cleanup is FINALLY done, and we can pivot to recovery-lane classification.

Per Amara: "Double-hop close is the active lane. Do not start branch/worktree recovery until: PR full archives are committed, LFG #845 artifacts are preserved, AceHack absorption completes, 0/0/0 is re-verified."

* tools/pr-preservation: archive-pr.sh — add GH_REPO env var override for cross-fork archives (Aaron 2026-04-29)

Per Aaron 2026-04-29: "respect GH_REPO we should fix"

The script previously hard-resolved the target repo via `gh repo view --json nameWithOwner`, which always returns the current-clone's repo (typically `Lucent-Financial-Group/Zeta`). For cross-fork archives — e.g., archiving an AceHack PR from a clone tracking LFG — this returned the wrong repo and the script either:
- Archived the WRONG PR (a same-numbered PR in the default repo), or
- Failed silently / produced misleading filename slugs.

Workaround: `gh repo set-default <fork>/<repo>` before running, then reset after. Awkward and error-prone.

Fix: the script now respects a `GH_REPO=<owner>/<name>` env var before falling back to `gh repo view`. Resolution order:

1. `GH_REPO` env var → use as `<owner>/<name>` (cross-fork archives)
2. `gh repo view --json nameWithOwner` → fall back to default-repo resolution

Also added an `<owner>/<name>` shape validator so a malformed GH_REPO value (no slash) hard-fails early instead of generating bogus output.

Verification: re-ran `GH_REPO=AceHack/Zeta tools/pr-preservation/archive-pr.sh 101` — script now correctly resolves to AceHack#101 and writes the archive with the right title/slug, instead of grabbing LFG/Zeta#101 (an unrelated 2026-04-22 PR with completely different content).

Cross-fork filename-collision discipline (separate convention, applied manually for now): when archiving cross-fork PRs that may have number collisions with the default repo, use a fork-prefixed filename like `PR-acehack-<NNNN>-<slug>.md`. This isn't yet in the tool — future enhancement candidate would auto-prefix when GH_REPO ≠ default-repo.

* ops: rename memory file to drop fork-prefix per Aaron's naming rule

Aaron 2026-04-29: "AceHack/Zeta we should not use a forks name in the main repo except for the special section for forks data that is unique to them like pr reviews, budgets, settings, maybe more."

Memory directory is general substrate, NOT a fork-specific section like docs/pr-discussions/ or docs/pr-preservation/. The fork-prefix in `feedback_acehack_zeta_*` filename was therefore misplaced — the file's content describes AceHack/Zeta-specific config but the filename shouldn't repeat that.

Renamed:
  memory/feedback_acehack_zeta_protection_config_dual_layer_legacy_deleted_rulesets_canonical_2026_04_29.md
→ memory/feedback_protection_config_dual_layer_legacy_deleted_rulesets_canonical_2026_04_29.md

Updated cross-references:
- memory/MEMORY.md (index pointer)
- docs/pr-discussions/PR-acehack-0101-...md (archive)
- docs/pr-discussions/PR-0844-...md (archive)
- docs/pr-discussions/PR-0845-...md (archive)
- docs/pr-preservation/lfg-844-drain-log.md
- docs/pr-preservation/acehack-101-drain-log.md

Fork-prefix discipline going forward (per Aaron):
- USE fork-prefix in: docs/pr-discussions/, docs/pr-preservation/, settings dirs, budget dirs (any fork-specific section)
- DO NOT USE fork-prefix in: memory/, src/, docs/ general areas, tools/, anywhere not explicitly fork-scoped

The file's CONTENT still references AceHack/Zeta as the specific repo it documents — that's substantive and correct. Just the filename doesn't repeat the fork name.

* ops: address LFG #846 Codex P2 — handle GH_REPO host-qualified form [HOST/]OWNER/REPO

Codex P2 (14:46Z): the GH_REPO override path I just added validates "contains a slash" but parses as if always `OWNER/REPO`. Per gh CLI docs GH_REPO accepts `[HOST/]OWNER/REPO` (host prefix optional, used by GitHub Enterprise). With a host-qualified value the previous parsing produced wrong owner+name.

Fix: case-statement parses both forms — 3-segment `HOST/OWNER/REPO` (take last two segments) and 2-segment `OWNER/REPO` (existing behavior). Added local sanity test confirming both parse correctly.

Edge cases now handled:
- `GH_REPO=AceHack/Zeta` → owner=AceHack, name=Zeta
- `GH_REPO=github.com/AceHack/Zeta` → owner=AceHack, name=Zeta (host stripped)
- `GH_REPO=enterprise.example.com/AceHack/Zeta` → owner=AceHack, name=Zeta (host stripped)
- `GH_REPO=Zeta` (no slash) → empty owner+name → fail loud with helpful error

This is a tiny CI/review correction per Amara's "don't expand #846 unless CI/review explicitly requires a tiny correction" guidance — Codex's catch is a real edge case, fix is small + isolated.

* ops(0-0-0): #846 review wave — strict GH_REPO validation + host propagation + drain-log corrections

Addresses 4 unresolved review threads on PR #846 that landed
2026-04-29T14:50:51Z..14:52:00Z, after auto-merge was armed.

tools/pr-preservation/archive-pr.sh:
- (Codex P2) Propagate parsed REPO_HOST to `gh api --hostname`.
  Previous parser captured the host segment from
  `GH_REPO=HOST/OWNER/REPO` then discarded it, so cross-fork
  archive runs against GitHub Enterprise repos silently
  targeted github.com. Now both `gh api graphql` calls in the
  Python child receive `--hostname HOST` when REPO_HOST is set.
- (Copilot P1) Strict GH_REPO validation. Previous parser
  accepted malformed values like `/repo`, `owner/`, and
  `owner/repo/extra` (the last would be parsed as
  host=owner / owner=repo / repo=extra). New rules:
  4+ segments rejected outright; 3-segment HOST/OWNER/REPO
  requires HOST to look like a hostname (contain a dot);
  embedded slashes inside owner/repo rejected as defence in
  depth against path-injection into docs/pr-discussions/.
  Verified locally against 10 edge cases (3 valid + 7 invalid).

docs/pr-preservation/acehack-101-drain-log.md:
- (Copilot P1) Thread 1 resolution: corrected the false
  claim that in-repo `memory/MEMORY.md` has a matching
  broken pointer. The user-scope MEMORY.md has the index
  entry; in-repo MEMORY.md does not. Backfill tracked
  under task #291.
- (Copilot P1) Lesson 3: rewritten as "pre-fix behavior"
  documenting how operators worked around the lack of
  GH_REPO support before this PR, with the post-fix
  command shape (`GH_REPO=fork/repo archive-pr.sh N`)
  and a forward pointer to task #314 for the fuller
  fork-routing patch.

memory/feedback_protection_config_dual_layer_legacy_deleted_rulesets_canonical_2026_04_29.md:
- Same false-pointer correction as the drain-log: the
  visibility-constraint memory exists in user-scope only;
  in-repo MEMORY.md does not index it. Pointer corrected
  to the user-scope path with task #291 forward link.

Test:
- `bash -n tools/pr-preservation/archive-pr.sh` passes.
- 10-case parser test (3 valid: owner/repo, github.com/owner/repo,
  github.example.com/owner/repo; 7 invalid: /repo, owner/,
  owner/repo/extra, host.com/owner/repo/extra, empty,
  owner-only, host.com//repo) all return expected rc + output.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* ops(0-0-0): retrigger CI on #846 — Code Quality CodeQL hit transient auth-service 401 at 15:00:42Z

The dynamic Code Scanning check (`Code Quality: PR #846`) failed
its SARIF upload step at 2026-04-29T15:00:42Z with:

  ##[warning]Requires authentication - https://docs.github.com/rest
  ##[error]Please check that your token is valid and has the
  required permissions: contents: read, security-events: write

Same window saw `gh api graphql` 401s on the maintainer laptop;
both cleared a few minutes later (gh works again with -X POST
flag). The Code Quality run is the dynamic-event variety that
cannot be retried via `gh run rerun --failed`. Empty commit is
the only way to retrigger.

Required-checks rollup is 7/7 SUCCESS; the Code Quality check is
a non-required gate that auto-merge waits on regardless. Diagnostic
runbook for this failure mode lives at memory/reference_gh_cli_*
(target home: docs/ops/runbooks/gh-cli-auth-401.md per Amara, follow-up).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
AceHack added a commit that referenced this pull request Apr 29, 2026
…GitHub PR/issue numbers

Copilot caught that committed substrate references like `#319` auto-link
to GitHub PR/issue 319 (a closed Graph operator-algebra PR), not to the
session-local TaskList task 319 (bounded-retry CodeQL flakes) I intended.
This is a generalized substrate-discipline issue: my TaskList tool's IDs
share the `#NNN` namespace with GitHub PR/issue numbers and silently mis-link.

Verified the collision against LFG/Zeta:
  task 313 → GH PR/issue 313: backlog: pre-landing sanitizer for ferry lint  [closed]
  task 314 → GH PR/issue 314: backlog: claude --agent harness flag           [closed]
  task 315 → GH PR/issue 315: core: Veridicality.canonicalKey                [closed]
  task 316 → GH PR/issue 316: adr: Graph substrate ZSet-backed retraction    [closed]
  task 317 → GH PR/issue 317: core: Graph substrate skeleton                  [closed]
  task 318 → GH PR/issue 318: backlog: P3 KSK naming definition doc           [closed]
  task 319 → GH PR/issue 319: core: Graph operator-algebra composition        [closed]
  task 320 → GH PR/issue 320: backlog: Schema-as-Graph first-class entities  [closed]
  task 321 → GH PR/issue 321: core: Graph.largestEigenvalue power iteration  [closed]

ALL 9 session-task IDs from this session collide.

Sweep: replaced `#NNN` → `task NNN` (no hash) in committed substrate where
the reference is to a session-local task. Real GitHub PR/commit refs
(#846, #847, #101, #103, #845, etc.) keep their `#` prefix.

Files swept (22 total replacements):
- docs/active-trajectory.md (8)
- docs/hygiene-history/ticks/2026/04/29/1517Z.md (9)
- memory/reference_gh_cli_graphql_401_diagnostic_runbook_2026_04_29.md (3)
- memory/MEMORY.md (2)

Lesson for future-self: TaskCreate/TaskList IDs are session-local and
share namespace with GitHub PR/issue numbers. When writing committed
substrate that references them, use `task NNN` (no hash) format. The
hash-prefix is reserved for real GitHub references that should auto-link.
This composes with the Drain-Log Claim Verification Discipline + the
index-vs-body single-source-of-truth discipline — claims about other
artifacts must reference the right artifact.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AceHack added a commit that referenced this pull request Apr 29, 2026
* ops(0-0-0): post-double-hop close — trajectory + tick shards + gh-401 runbook (interim memory home)

The post-double-hop close artifacts:

- docs/active-trajectory.md: priority section RE-CLOSED (rescinds the
  "blocking all other work" framing now that 0/0/0 holds again at
  17a2637). New "Post-double-hop
  sequencing" block lists the next-lane order per Amara: #315
  (hourly budget), #319 (bounded-retry CodeQL), #318 (docs/ops
  taxonomy), #317 (tick-fast-path), #316 (absorbed into #318),
  #313/#314, then branch/worktree recovery.

- docs/hygiene-history/ticks/2026/04/29/1452Z.md: tick shard for the
  PR #846 review wave (4 unresolved threads — 3× Copilot P1 +
  1× Codex P2). Codex caught the structurally-deepest bug (host
  segment parsed but discarded silently before gh api graphql);
  Copilot caught the surface P1s. Review-ensemble complementarity.

- docs/hygiene-history/ticks/2026/04/29/1517Z.md: tick shard for the
  0/0/0 re-close ceremony at 15:17:09Z. Force-with-lease + ruleset
  toggle/restore + verify. Aaron's "why are you waiting on me"
  flagged as future-self lesson on standing-authority cadence
  (Otto-359 candidate).

- memory/reference_gh_cli_graphql_401_diagnostic_runbook_2026_04_29.md:
  diagnostic runbook for the gh CLI auth glitch where `gh api
  graphql` 401s while `gh api -X POST graphql` works. Amara
  framing: diagnostic note, not doctrine yet. INTERIM HOME: the
  runbook lives in memory/ for this round; long-term home is
  docs/ops/runbooks/gh-cli-auth-401.md per task #318
  (docs/ops taxonomy — runbooks/patterns/incidents/ tree).

- memory/MEMORY.md: paired index entry for the runbook above
  (per memory-index-integrity rule).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* ops(0-0-0): #847 Codex P2 — correct gh-401 runbook misdiagnosis (X POST is a no-op)

Codex P2 on PR #847: my prior runbook claimed `gh api graphql -f query='...'`
defaults to GET and that `-X POST` was the workaround. That's wrong: `gh api`
already sends POST when `-f` or `-F` parameters are present (per `gh api --help`).
The earlier "the X flag fixed it" observation was actually the upstream
auth-service glitch resolving in the few seconds between attempts —
misattributed.

Empirical verification:

  GH_DEBUG=api gh api graphql -f query='query { viewer { login } }' 2>&1 \
    | grep -E '^> POST|^> GET'
  # > POST /graphql HTTP/1.1   ← already POST without -X

Updated runbook to:
- Frame the failure mode correctly: transient upstream auth-service
  hiccup that recovers on its own (~30-90s window). Bounded retry is
  the answer, not flag-magic.
- Add explicit "Common misdiagnosis (corrected)" section so future-
  self doesn't re-derive the wrong fix.
- Keep CodeQL SARIF upload 401 as sibling failure mode (independently
  observed in CodeQL run logs, not the misattributed-flag failure).
- Cross-reference task #319 (bounded-retry CodeQL) for the durable
  fix Aaron specified per DST discipline.

Lesson captured in trigger-memory section: claim-without-verify is
the failure mode the Drain-Log Claim Verification Discipline (task
#316) catches. The rule applies to runbook-authoring in real time,
not just retroactive drain-log audits.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* ops(0-0-0): #847 retrigger — clear stale submit-nuget failure on deleted misnamed branch

Earlier in this PR's history, a push hit a misnamed branch on LFG
(post-0-0-0-reclose-followup-acehack-2026-04-29 instead of the lfg-named
counterpart). I corrected the push and the misnamed branch was later
auto-deleted. However, the submit-nuget workflow had already been
triggered against that branch and is now stuck because a rerun cannot
re-fetch the deleted ref.

The same SHA (65b20ee) has a SUCCESS run on the correct lfg-named
branch (run 25117920779), but the rollup also retains the FAILURE run
from the deleted branch (run 25117911328). Auto-merge BLOCKED on the
stale failure status.

Empty commit retrigger to land a fresh SHA where workflows fire only
on the correct branch context. No content change.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* ops(0-0-0): #847 review wave 2 — Copilot + 2× Codex corrections

Three unresolved review threads on #847 head, all valid:

1. Copilot — tick shard filename mismatch
   `1452Z.md` filename vs `14:58:00Z` row timestamp confused
   chronological sort. Renamed file to `1458Z.md` to match the
   row timestamp (the row had been revised when the round-close
   landed, but I forgot to rename the file).

2. Codex P1 — `gh api rate_limit` is not a reliable auth-health
   signal. Per GitHub REST docs, `GET /rate_limit` succeeds
   anonymously when only public resources are queried, so a
   missing/revoked token can show as healthy on this check.
   Replaced runbook step 3 with `gh api user` (requires auth,
   no anonymous fallback). Also corrected the "still works"
   block to call out the same caveat with explicit Codex P1
   credit + cross-reference to PR #847.

3. Codex P2 — frontmatter description over-asserted "not a
   token problem" while the body documents token-side branches.
   Softened to "FIRST hypothesis is transient upstream...
   always rule out token-side issues before assuming transient."
   Indexes/previews surfacing the description now don't
   short-circuit to "must be transient, retry."

The Codex P1 correction is structurally important: a runbook
that misclassifies "token problem" as "transient" delays the
real remediation path. Caught proactively before any operator
ran the broken triage.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* ops(0-0-0): #847 Codex P2 — fix stale -X POST claim in MEMORY.md index entry

Codex P2 caught that the MEMORY.md index entry I added still
referenced the old misdiagnosis (gh api -X POST works while gh api
graphql doesn't). The runbook itself was corrected, but the index
entry wasn't updated to match — readers seeing the index first
would be sent back toward the already-invalidated method-switch
theory instead of the intended transient-auth/token diagnosis.

Updated MEMORY.md index entry to:
- Remove the -X POST contrast claim
- Frame as "transient upstream auth-service 401s" first-hypothesis
- Cross-reference the Codex P2 correction with explicit credit
- Note token-side cases explicitly ("always rule out token-side
  issues — expired/revoked/SSO — before assuming transient")

Future-self lesson reinforced: when correcting a substrate file,
update ALL surfaces that reference its claims — body text, frontmatter,
INDEX entries, cross-refs in other files. Codex P2 caught what would
have been a silent-state-divergence between the runbook and its index.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* ops(0-0-0): #847 Copilot wave 4 — disambiguate session-task IDs from GitHub PR/issue numbers

Copilot caught that committed substrate references like `#319` auto-link
to GitHub PR/issue 319 (a closed Graph operator-algebra PR), not to the
session-local TaskList task 319 (bounded-retry CodeQL flakes) I intended.
This is a generalized substrate-discipline issue: my TaskList tool's IDs
share the `#NNN` namespace with GitHub PR/issue numbers and silently mis-link.

Verified the collision against LFG/Zeta:
  task 313 → GH PR/issue 313: backlog: pre-landing sanitizer for ferry lint  [closed]
  task 314 → GH PR/issue 314: backlog: claude --agent harness flag           [closed]
  task 315 → GH PR/issue 315: core: Veridicality.canonicalKey                [closed]
  task 316 → GH PR/issue 316: adr: Graph substrate ZSet-backed retraction    [closed]
  task 317 → GH PR/issue 317: core: Graph substrate skeleton                  [closed]
  task 318 → GH PR/issue 318: backlog: P3 KSK naming definition doc           [closed]
  task 319 → GH PR/issue 319: core: Graph operator-algebra composition        [closed]
  task 320 → GH PR/issue 320: backlog: Schema-as-Graph first-class entities  [closed]
  task 321 → GH PR/issue 321: core: Graph.largestEigenvalue power iteration  [closed]

ALL 9 session-task IDs from this session collide.

Sweep: replaced `#NNN` → `task NNN` (no hash) in committed substrate where
the reference is to a session-local task. Real GitHub PR/commit refs
(#846, #847, #101, #103, #845, etc.) keep their `#` prefix.

Files swept (22 total replacements):
- docs/active-trajectory.md (8)
- docs/hygiene-history/ticks/2026/04/29/1517Z.md (9)
- memory/reference_gh_cli_graphql_401_diagnostic_runbook_2026_04_29.md (3)
- memory/MEMORY.md (2)

Lesson for future-self: TaskCreate/TaskList IDs are session-local and
share namespace with GitHub PR/issue numbers. When writing committed
substrate that references them, use `task NNN` (no hash) format. The
hash-prefix is reserved for real GitHub references that should auto-link.
This composes with the Drain-Log Claim Verification Discipline + the
index-vs-body single-source-of-truth discipline — claims about other
artifacts must reference the right artifact.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants